search

jmongard / Git.SemVersioning.Gradle

Gradle plugin for automatically versioning a project using semantic versioning and conventional commits with change log support based on git commit messages.
https://plugins.gradle.org/plugin/com.github.jmongard.git-semver-plugin
Apache License 2.0
38 stars 4 forks source link

Release 0.12.0 removes `isPreRelease` from `SemVer`, making it a breaking change #51

Closed sschuberth closed 7 months ago

sschuberth commented 7 months ago

In SemVer we used to have

val isPreRelease
    get() = preRelease.isPreRelease

which is gone now. Was this intended? I was actually using this property, so version 0.12.0 is a breaking release (requiring a major version bump) for me.

sschuberth commented 7 months ago

Now I need to call preRelease.isPreRelease, which looks awkward. (Why should a pre-release not be a pre-release?)

jmongard commented 7 months ago

Yes, that would be ugly. Ill just add it back again. It got lost when I split the SemVersion class into three.

sschuberth commented 7 months ago

Yes, that would be ugly. Ill just add it back again. It got lost when I split the SemVersion class into three.

Thanks. When you do a new release, please include https://github.com/jmongard/Git.SemVersioning.Gradle/pull/52 as well 😉

jmongard commented 7 months ago

It should be back now in 0.12.2