search

jmongard / Git.SemVersioning.Gradle

Gradle plugin for automatically versioning a project using semantic versioning and conventional commits with change log support based on git commit messages.
https://plugins.gradle.org/plugin/com.github.jmongard.git-semver-plugin
Apache License 2.0
38 stars 4 forks source link

`-PnoDirtyCheck=true` no longer works #55

Closed tacascer closed 7 months ago

tacascer commented 7 months ago

It seems that -PnoDirtyCheck=true is no longer being honored by the releaseVersion task.

A short investigation shows that the task defaults the property to false here.

The only manipulation of the field I can find is here.

It seems that the property is not being passed down from the settings object passed in.

jmongard commented 7 months ago

Ok, I will look in to it

jmongard commented 7 months ago

This problem is fixed in 0.12.5. It were caused by requirement to reading properties lazy to make configuration cache work. The properties were only read when using the print tasks but not when using the release task.