Closed jmonlong closed 5 years ago
I've done a bunch of these way back when. Ex Figure three from https://www.biorxiv.org/content/10.1101/101378v1.full, but they all emphasize sample graphs and augmentation which aren't so relevant here.
I think a cartoon is the way to go, where reads support two paths through the graph and the reference path is indicated and a VCF line comes out the other end. Adding some reads to your cartoon would probably work, otherwise maybe marking up a small tubemap?
Here is what I wanted to make for Wednesday's presentation but didn't have time. For the paper maybe something like the bottom part is enough. The google drawing if someone feel like tweaking it.
Are we discussing snarls in the text? I wonder if the term might be a little unclear. We could just call them bubbles.
On Fri, May 10, 2019, 08:21 Jean Monlong notifications@github.com wrote:
Here is what I wanted to make for Wednesday's presentation but didn't have time. For the paper maybe something like the bottom part is enough. The google drawing https://docs.google.com/drawings/d/1yiUkcnC5XCwfVBn-EB-09mjzamBZV8YR-VKVU15RJX0/edit?usp=sharing if someone feel like tweaking it.
[image: mapping-geno-insertion-linear-vs-graph] https://user-images.githubusercontent.com/5704457/57506366-78529780-72b0-11e9-88ba-6e981e791bff.jpg
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/jmonlong/manu-vgsv/issues/70#issuecomment-491171227, or mute the thread https://github.com/notifications/unsubscribe-auth/AABDQEKDC4GY2KOMY6U3KL3PUUIAHANCNFSM4HKXUAMA .
Yes, snarls are discussed in the Methods section. I have made an attempt of taking Jean's drawing and focusing on the bottom part so that we can use it as Figure 1a. What do you think?
Looks good, more compact, I like it.
Yes the idea was to illustrate the "call algorithm" in the methods section that talks about coverage, snarls, paths. We could also use bubble in the fig 1a and in the method section refer to them when introducing snarls.
Yeah, thanks. This is looking good. I don't think we want to show a SNP though as it's not super relevant to the text. I will try to change it to an inversion or deletion.
On Fri, May 10, 2019 at 1:52 PM Jean Monlong notifications@github.com wrote:
Looks good, more compact, I like it.
Yes the idea was to illustrate the "call algorithm" in the methods section that talks about coverage, snarls, paths. We could also use bubble in the fig 1a and in the method section refer to them when introducing snarls.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jmonlong/manu-vgsv/issues/70#issuecomment-491376425, or mute the thread https://github.com/notifications/unsubscribe-auth/AAG373SUE4LREW6MVRU7HVLPUWY6LANCNFSM4HKXUAMA .
I think Glenn's version is good for fig1a so I just merged the corresponding PR #81.
I move the fig1a (the cartoon that shows what a structural variant looks in the graph) to the supplement with the text introducing genome graphs. A better fig1a would be a cartoon that shows the genotyping algo described at the begining of the results section. Maybe something that shows:
We could either start from the cartoon I made (former fig1a) or one of Erik's figure like Glenn suggested. Or maybe we already have this kind of illustration somewhere? @glennhickey @adamnovak did you ever used something like that to explain the genotyping approach?