search

jmons / ramlwrap

Wrapping Raml around Django rest-api's
MIT License
8 stars 2 forks source link

CSRF Exemption Removed #22

Closed jmons closed 6 years ago

jmons commented 7 years ago

This has a new set of tests specifically to look at issue #14, but even with the @csrf_exempt decorator removed, I can't find any issues.

I don't think this is needed for a release right now, but I would like to merge it in ready for whatever feature comes next.

jmons commented 7 years ago

Ooh now that's interesting, because I ran all the tox tests before committing and pushing (screen grab from local tox:

screen shot 2017-03-28 at 23 21 03

I will have to look at this later.

Jamian commented 7 years ago

I gave tox a run locally and get fails for py27-django7 and py3-django7... same as the travis.

Not sure how your local ran fine.

image

jmons commented 7 years ago

Ok, if I force tox to reload its cache (tox -r) then this now fails on my local machine. I wonder if django7 is now a broken install?

jmons commented 7 years ago

Dave has graciously found the cause - there is a django change (the builds worked fine for him on his mac) so I'm going to reverse-merge again, and re-run the tests.

jmons commented 6 years ago

Closing as not part of RC2 structure: this code has been completly re-written.