jmonta01 / somafm-webplayer

A modern web player to stream soma fm radio stations.
Apache License 2.0
21 stars 6 forks source link

Player controls stick when stopping a stream #2

Open jmonta01 opened 10 years ago

jmonta01 commented 10 years ago

Play a stream and the player controls show up above the nav. Stop the stream (not pause) and the player controls hide, but the ui does not update properly.

rustyhodge commented 10 years ago

This might have to do with the fact that we're redirecting PLS files from Safari to itunes:// URLs to make them launch iTunes rather than play with a grey box in Safari.

You should try parsing out the first entry in the PLS file, and opening that directly instead maybe.

jmonta01 commented 10 years ago

Ah. Yeah that makes sense! So I'm loading the pls via ajax to create the list of streams to cycle through. Basically emulating what the flash client is doing. Is that pls generated by you or is it automated from somewhere else like shoutcast? Worst case scenario we may have to make an adapter script on the server side. Loads the pls on the server and returns XML or json

Sent with AquaMail for Android http://www.aqua-mail.com

On June 2, 2014 6:06:23 PM Rusty Hodge notifications@github.com wrote:

This might have to do with the fact that we're redirecting PLS files from Safari to itunes:// URLs to make them launch iTunes rather than play with a grey box in Safari.

You should try parsing out the first entry in the PLS file, and opening that directly instead maybe.


Reply to this email directly or view it on GitHub: https://github.com/jmonta01/somafm-webplayer/issues/2#issuecomment-44902108

rustyhodge commented 10 years ago

Is that pls generated by you

Yes, it is generated by us.

I have a solution. I modified the HTTP rewrite to not rewrite safari calls if there is a query string of popup:

http://somafm.com/secretagent.pls?popup

You should be able to append that onto all your calls from the HTML5 player on any device and it should work. Can you do that?

jmonta01 commented 10 years ago

Sure I'll give it a try. Sounds like it should work. I left my Mac at work so won't be able to test on safari. I'll sent an email when the release is ready

Sent with AquaMail for Android http://www.aqua-mail.com

On June 2, 2014 6:39:10 PM Rusty Hodge notifications@github.com wrote:

Is that pls generated by you

Yes, it is generated by us. I have a solution. I modified the HTTP rewrite to not rewrite safari calls if there is a query string of popup:

http://somafm.com/secretagent.pls?popup

You should be able to append that onto all your calls from the HTML5 player on any device and it should work. Can you do that?


Reply to this email directly or view it on GitHub: https://github.com/jmonta01/somafm-webplayer/issues/2#issuecomment-44904282

jmonta01 commented 10 years ago

Alright I just created a new release. I had to edit it directly on github, so hopefully everything is cool. Let me know when you get it up there.

https://github.com/jmonta01/somafm-webplayer/releases/tag/0.0.4

Thanks, Jason

On 6/2/2014 6:39 PM, Rusty Hodge wrote:

Is that pls generated by you

Yes, it is generated by us.

I have a solution. I modified the HTTP rewrite to not rewrite safari calls if there is a query string of popup:

http://somafm.com/secretagent.pls?popup

You should be able to append that onto all your calls from the HTML5 player on any device and it should work. Can you do that?

— Reply to this email directly or view it on GitHub https://github.com/jmonta01/somafm-webplayer/issues/2#issuecomment-44904282.

rustyhodge commented 10 years ago

It indeed is playing on Safari now. Great!

This image is still missing, http://somafm.com/dist/images/a41f4cd4.list_header.jpg or else the path is wrong / has a leading slash / and poinging to http://somafm.com/images/a41f4cd4.list_header.jpg

Where is that set in the code? I can update and redeploy.

Thanks!

On Jun 2, 2014, at 7:59 PM, Jason Montalto notifications@github.com wrote:

Alright I just created a new release. I had to edit it directly on github, so hopefully everything is cool. Let me know when you get it up there.

https://github.com/jmonta01/somafm-webplayer/releases/tag/0.0.4

Thanks, Jason

On 6/2/2014 6:39 PM, Rusty Hodge wrote:

Is that pls generated by you

Yes, it is generated by us.

I have a solution. I modified the HTTP rewrite to not rewrite safari calls if there is a query string of popup:

http://somafm.com/secretagent.pls?popup

You should be able to append that onto all your calls from the HTML5 player on any device and it should work. Can you do that?

— Reply to this email directly or view it on GitHub https://github.com/jmonta01/somafm-webplayer/issues/2#issuecomment-44904282.

— Reply to this email directly or view it on GitHub.

jmonta01 commented 10 years ago

That is fantastic! I patched the dist code and made a 5th release. But there must be a bug somewhere that is causing this. I will take a look at it. I probably have something tweaked in my grunt configuration. The dist code is generated from the app code, so patching the dist code is a temp solve. But, in the mean time, you can deploy this code to fix the issue: https://github.com/jmonta01/somafm-webplayer/releases/tag/0.0.5

Thanks, Jason

On 6/2/2014 10:59 PM, Rusty Hodge wrote:

It indeed is playing on Safari now. Great!

This image is still missing, http://somafm.com/dist/images/a41f4cd4.list_header.jpg or else the path is wrong / has a leading slash / and poinging to http://somafm.com/images/a41f4cd4.list_header.jpg

Where is that set in the code? I can update and redeploy.

Thanks!

On Jun 2, 2014, at 7:59 PM, Jason Montalto notifications@github.com wrote:

Alright I just created a new release. I had to edit it directly on github, so hopefully everything is cool. Let me know when you get it up there.

https://github.com/jmonta01/somafm-webplayer/releases/tag/0.0.4

Thanks, Jason

On 6/2/2014 6:39 PM, Rusty Hodge wrote:

Is that pls generated by you

Yes, it is generated by us.

I have a solution. I modified the HTTP rewrite to not rewrite safari calls if there is a query string of popup:

http://somafm.com/secretagent.pls?popup

You should be able to append that onto all your calls from the HTML5 player on any device and it should work. Can you do that?

— Reply to this email directly or view it on GitHub

https://github.com/jmonta01/somafm-webplayer/issues/2#issuecomment-44904282.

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHub https://github.com/jmonta01/somafm-webplayer/issues/2#issuecomment-44917668.

rustyhodge commented 10 years ago

Sorry, was out today. The Version 6 doesn't seem to work at all.

On Jun 2, 2014, at 9:14 PM, Jason Montalto notifications@github.com wrote:

That is fantastic! I patched the dist code and made a 5th release. But there must be a bug somewhere that is causing this. I will take a look at it. I probably have something tweaked in my grunt configuration. The dist code is generated from the app code, so patching the dist code is a temp solve. But, in the mean time, you can deploy this code to fix the issue: https://github.com/jmonta01/somafm-webplayer/releases/tag/0.0.5

Thanks, Jason

On 6/2/2014 10:59 PM, Rusty Hodge wrote:

It indeed is playing on Safari now. Great!

This image is still missing, http://somafm.com/dist/images/a41f4cd4.list_header.jpg or else the path is wrong / has a leading slash / and poinging to http://somafm.com/images/a41f4cd4.list_header.jpg

Where is that set in the code? I can update and redeploy.

Thanks!

On Jun 2, 2014, at 7:59 PM, Jason Montalto notifications@github.com wrote:

Alright I just created a new release. I had to edit it directly on github, so hopefully everything is cool. Let me know when you get it up there.

https://github.com/jmonta01/somafm-webplayer/releases/tag/0.0.4

Thanks, Jason

On 6/2/2014 6:39 PM, Rusty Hodge wrote:

Is that pls generated by you

Yes, it is generated by us.

I have a solution. I modified the HTTP rewrite to not rewrite safari calls if there is a query string of popup:

http://somafm.com/secretagent.pls?popup

You should be able to append that onto all your calls from the HTML5 player on any device and it should work. Can you do that?

— Reply to this email directly or view it on GitHub

https://github.com/jmonta01/somafm-webplayer/issues/2#issuecomment-44904282.

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHub https://github.com/jmonta01/somafm-webplayer/issues/2#issuecomment-44917668.

— Reply to this email directly or view it on GitHub.

jmonta01 commented 10 years ago

No problem. Looks like I blew it on adding the generated files to github again. I'll get one ready for tonight. Sorry about that

Sent with AquaMail for Android http://www.aqua-mail.com

On June 5, 2014 1:19:43 AM Rusty Hodge notifications@github.com wrote:

Sorry, was out today. The Version 6 doesn't seem to work at all.

On Jun 2, 2014, at 9:14 PM, Jason Montalto notifications@github.com wrote:

That is fantastic! I patched the dist code and made a 5th release. But there must be a bug somewhere that is causing this. I will take a look at it. I probably have something tweaked in my grunt configuration. The dist code is generated from the app code, so patching the dist code is a temp solve. But, in the mean time, you can deploy this code to fix the issue: https://github.com/jmonta01/somafm-webplayer/releases/tag/0.0.5 Thanks, Jason On 6/2/2014 10:59 PM, Rusty Hodge wrote: > It indeed is playing on Safari now. Great! > > This image is still missing, > http://somafm.com/dist/images/a41f4cd4.list_header.jpg > or else the path is wrong / has a leading slash / and poinging to > http://somafm.com/images/a41f4cd4.list_header.jpg > > Where is that set in the code? I can update and redeploy. > > Thanks! > > On Jun 2, 2014, at 7:59 PM, Jason Montalto notifications@github.com > wrote: > > > Alright I just created a new release. I had to edit it directly on > > github, so hopefully everything is cool. Let me know when you get it up > > there. > >

https://github.com/jmonta01/somafm-webplayer/releases/tag/0.0.4 > > > > Thanks, > > Jason > > > > On 6/2/2014 6:39 PM, Rusty Hodge wrote: > > > > Is that pls generated by you > > > > > > Yes, it is generated by us. > > >

I have a solution. I modified the HTTP rewrite to not rewrite safari calls if there is a query string of popup: > > > > > > http://somafm.com/secretagent.pls?popup > > > > > > You should be able to append that onto all your calls from the HTML5 > > > player on any device and it should work. Can you do that? > > > > > > — > > > Reply to this email directly or view it on GitHub > > > > https://github.com/jmonta01/somafm-webplayer/issues/2#issuecomment-44904282.

— > > Reply to this email directly or view it on GitHub. > > > — > Reply to this email directly or view it on GitHub > https://github.com/jmonta01/somafm-webplayer/issues/2#issuecomment-44917668.

— Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHub: https://github.com/jmonta01/somafm-webplayer/issues/2#issuecomment-45184605

rustyhodge commented 10 years ago

Can you give some instructions on how to build it from the source?

On Jun 5, 2014, at 7:23 AM, Jason Montalto notifications@github.com wrote:

No problem. Looks like I blew it on adding the generated files to github again. I'll get one ready for tonight. Sorry about that

Sent with AquaMail for Android http://www.aqua-mail.com

On June 5, 2014 1:19:43 AM Rusty Hodge notifications@github.com wrote:

Sorry, was out today. The Version 6 doesn't seem to work at all.

On Jun 2, 2014, at 9:14 PM, Jason Montalto notifications@github.com wrote:

That is fantastic! I patched the dist code and made a 5th release. But there must be a bug somewhere that is causing this. I will take a look at it. I probably have something tweaked in my grunt configuration. The dist code is generated from the app code, so patching the dist code is a temp solve. But, in the mean time, you can deploy this code to fix the issue: https://github.com/jmonta01/somafm-webplayer/releases/tag/0.0.5 Thanks, Jason On 6/2/2014 10:59 PM, Rusty Hodge wrote: > It indeed is playing on Safari now. Great! > > This image is still missing, > http://somafm.com/dist/images/a41f4cd4.list_header.jpg > or else the path is wrong / has a leading slash / and poinging to > http://somafm.com/images/a41f4cd4.list_header.jpg > > Where is that set in the code? I can update and redeploy. > > Thanks! > > On Jun 2, 2014, at 7:59 PM, Jason Montalto notifications@github.com > wrote: > > > Alright I just created a new release. I had to edit it directly on > > github, so
hopefully everything is cool. Let me know when you get it up > > there. > >

https://github.com/jmonta01/somafm-webplayer/releases/tag/0.0.4 > > > > Thanks, > > Jason > > > > On 6/2/2014 6:39 PM, Rusty Hodge wrote: > > > > Is that pls generated by you > > > > > > Yes, it is generated by us. > > >

I have a solution. I modified the HTTP rewrite to not rewrite safari calls if there is a query string of popup: > > > > > > http://somafm.com/secretagent.pls?popup > > > > > > You should be able to append that onto all your calls from the HTML5 > > > player on any device and it should work. Can you do that? > > > > > > — > > > Reply to this email directly or view it on GitHub > > > > https://github.com/jmonta01/somafm-webplayer/issues/2#issuecomment-44904282.

— > > Reply to this email directly or view it on GitHub. > > > — > Reply to this email directly or view it on GitHub > https://github.com/jmonta01/somafm-webplayer/issues/2#issuecomment-44917668.

— Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHub: https://github.com/jmonta01/somafm-webplayer/issues/2#issuecomment-45184605 — Reply to this email directly or view it on GitHub.

jmonta01 commented 10 years ago

Hey Rusty,

I added instructions to the ReadMe on the repo. If you need help getting setup (ie git, ruby, etc...) beyond that, let me know. I also created the 7th release. Just to be sure I tested it on a different ubuntu machine which looked to work. :-)

https://github.com/jmonta01/somafm-webplayer/releases/tag/0.0.7

Thanks, Jason

On 6/5/2014 12:01 PM, Rusty Hodge wrote:

Can you give some instructions on how to build it from the source?

On Jun 5, 2014, at 7:23 AM, Jason Montalto notifications@github.com wrote:

No problem. Looks like I blew it on adding the generated files to github again. I'll get one ready for tonight. Sorry about that

Sent with AquaMail for Android http://www.aqua-mail.com

On June 5, 2014 1:19:43 AM Rusty Hodge notifications@github.com wrote:

Sorry, was out today. The Version 6 doesn't seem to work at all.

On Jun 2, 2014, at 9:14 PM, Jason Montalto notifications@github.com wrote:

That is fantastic! I patched the dist code and made a 5th release. But there must be a bug somewhere that is causing this. I will take a look at it. I probably have something tweaked in my grunt configuration. The dist code is generated from the app code, so patching the dist code is a temp solve. But, in the mean time, you can deploy this code to fix the issue: https://github.com/jmonta01/somafm-webplayer/releases/tag/0.0.5 Thanks, Jason On 6/2/2014 10:59 PM, Rusty Hodge wrote: > It indeed is playing on Safari now. Great! > > This image is still missing, > http://somafm.com/dist/images/a41f4cd4.list_header.jpg > or else the path is wrong / has a leading slash / and poinging to > http://somafm.com/images/a41f4cd4.list_header.jpg > > Where is that set in the code? I can update and redeploy. > > Thanks! > > On Jun 2, 2014, at 7:59 PM, Jason Montalto notifications@github.com > wrote: > > > Alright I just created a new release. I had to edit it directly on > > github, so hopefully everything is cool. Let me know when you get it up > > there. > >

https://github.com/jmonta01/somafm-webplayer/releases/tag/0.0.4 > > > > Thanks, > > Jason > > > > On 6/2/2014 6:39 PM, Rusty Hodge wrote:

Is that pls generated by you > > > > > > Yes, it is generated by us. > > >

I have a solution. I modified the HTTP rewrite to not rewrite safari calls if there is a query string of popup: > > > > > > http://somafm.com/secretagent.pls?popup > > > > > > You should be able to append that onto all your calls from the HTML5 > > > player on any device and it should work. Can you do that? > > > > > > — > > > Reply to this email directly or view it on GitHub > > > >

https://github.com/jmonta01/somafm-webplayer/issues/2#issuecomment-44904282.

— > > Reply to this email directly or view it on GitHub. > > > — > Reply to this email directly or view it on GitHub >

https://github.com/jmonta01/somafm-webplayer/issues/2#issuecomment-44917668.

— Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHub:

https://github.com/jmonta01/somafm-webplayer/issues/2#issuecomment-45184605 — Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHub https://github.com/jmonta01/somafm-webplayer/issues/2#issuecomment-45245970.