search

jmoon018 / PacVim

GNU Lesser General Public License v3.0
3.25k stars 193 forks source link

Full Makefile added, custom maps location support #17

Closed bfontaine closed 9 years ago

bfontaine commented 9 years ago

Hello again, This PR adds a full Makefile which features separate compilation tasks, and install/uninstall targets, with support for a custom maps location.

It allows you to type:

make
[sudo] make install

to install the game and have it in your PATH (so you can just type pacvim and it launches it), as well as make uninstall to uninstall it.

The downside is that the maps directory location is fixed when the binary is compiled (which was already the case), which means you have to recompile it when you install it somewhere else. By default, the maps location is at /usr/local/share/pacvim-maps/. You can revert to the original behavior by running make MAPDIR=maps.

Feel free to comment on the code if you have any question.

The initial motivation for this PR was that with Homebrew, binaries are installed in a bin directory and other files in another directory, which means we have to patch the code before installing.

jmoon018 commented 9 years ago

@bfontaine Awesome! I tested it on Ubuntu and OS X, and they both worked great. Thanks! Merging

bfontaine commented 9 years ago

Would you mind making a new release tag? That’ll be the last thing before the inclusion in Homebrew :smiley: Thanks!

jmoon018 commented 9 years ago

@bfontaine

Done!

bfontaine commented 9 years ago

Thanks, I’ll comment here when it’ll be included :) (the PR is here: Homebrew/homebrew#36210)

jmoon018 commented 9 years ago

Awesome, I look forward to it! Thanks a ton

bfontaine commented 9 years ago

It has been merged, Homebrew users can now install PacVim with brew install pacvim :)