jmoor3 / homeassistant-components

3 stars 19 forks source link

>0.89 compliant - "packaged" - 3rd pump integration - code cleanup - and more... #8

Closed plmilord closed 4 years ago

plmilord commented 5 years ago

What's different:

stringy92 commented 4 years ago

@plmilord - I have tried the latest fix but still suffering the same issues as above

When the hot tub is set to Fahrenheit the HA display shows - 38.2 When the hot tub is set to Celsius the HA display shows - 77

plmilord commented 4 years ago

Ok I see…

My spa is set to Fahrenheit and my HA is set to Fahrenheit too… (work fine)! But like you, when I switch my spa to Celsius, the display double! I'll give it a look!

plmilord commented 4 years ago

Solved in this morning upload! Do not hesitate to test and confirm!

stringy92 commented 4 years ago

@plmilord Works really nicely! I did get this error however, and it caused my HA to lock up, and unable to access so i had to reboot

2020-05-14 13:51:54 ERROR (MainThread) [homeassistant.helpers.entity] Update for switch.spa_pump_1 fails Traceback (most recent call last): File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 279, in async_update_ha_state await self.async_device_update() File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 470, in async_device_update await self.async_update() File "/config/custom_components/spaclient/switch.py", line 67, in async_update self._spa.read_all_msg() File "/config/custom_components/spaclient/spaclient.py", line 172, in read_all_msg while (self.read_msg()): File "/config/custom_components/spaclient/spaclient.py", line 150, in read_msg length = len_chunk[1] IndexError: index out of range

Ive added a Hastebin link, as you can read this easierhttps://hastebin.com/eyinisidoz.sql

stringy92 commented 4 years ago

Just had similar issue, which caused HA to become unresponsive

2020-05-14 21:13:55 ERROR (MainThread) [homeassistant.helpers.entity] Update for light.spa_light fails Traceback (most recent call last): File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 279, in async_update_ha_state await self.async_device_update() File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 470, in async_device_update await self.async_update() File "/config/custom_components/spaclient/light.py", line 46, in async_update self._spa.read_all_msg() File "/config/custom_components/spaclient/spaclient.py", line 172, in read_all_msg while (self.read_msg()): File "/config/custom_components/spaclient/spaclient.py", line 150, in read_msg length = len_chunk[1] IndexError: index out of range

plmilord commented 4 years ago

Weird!? Have update every files in your "spaclient" folder? Be sure to dl all the latest files to go trought that folder name change (SpaClient -to- spaclient). I never had those error msg!?

I also had instabilities with HA in past weeks. Since the last update, everything's seem to be fine for me. But in my case, that was not related to this custom component!

Change your setup to fahrenheit for next days and let me know if that bug come back!

Thanks for you follow-up!

plmilord commented 4 years ago

stringy92 , have you gone through your problem?