59-BUNSPACE2024-Add-New-Styling-For-Background

[jmorales8]

add switch night mode button and dark theme in the background, will be adding a moon or someshit in the back

Extra Resources

• The 10 commandments of navigating code reviews
• Google's Code Review Developer Guide

Closes [#59, #56, #57 ]

[GrpFruit]

moral of the story add empty lines at the end of files when switching tabs on the nav bar the night mode effect doesn't stay also, the footer and nav bar don't change color either

edit: how did you get the dark mode color? try looking for a color palette that goes with the main theme so it makes sense visually

[jmorales8]

moral of the story add empty lines at the end of files when switching tabs on the nav bar the night mode effect doesn't stay also, the footer and nav bar don't change color either

edit: how did you get the dark mode color? try looking for a color palette that goes with the main theme so it makes sense visually

So the reason why this doesnt work currently is because the way our navbar works. Its currently using <a> tag links so when it goes to a new page, it refreshes and loads everything which is bad and resets the state of everything, including the music component and the theme too. In the music pr, we switched to react routers <Links> which DOES NOT refresh the next page and simply loads the component while keeping the state the same. This can be seen if you click the pillow icon at the top right which does use <Link>. In conclusion, it does work assuming i can get the pr for music in and we can get a new better navbar

As for the styling the other components have their own styling but there isnt a set color palete. However, pillow did give be a base color and went off from there. I was just going off of what looks good. The purple was here idea

[GrpFruit]

show her color palettes and have her choose the one she likes best, I bet its a burden for her to pick colors out of thin air and not knowing how they look after it's on the page. https://www.color-hex.com/color/eecbcb I personally like this color for darkmode

[jmorales8]

show her color palettes and have her choose the one she likes best, I bet its a burden for her to pick colors out of thin air and not knowing how they look after it's on the page. https://www.color-hex.com/color/eecbcb I personally like this color for darkmode

I dont, imo. It looks rotten asf like as if it an actual bunny was mudered xd

[GrpFruit]

show her color palettes and have her choose the one she likes best, I bet its a burden for her to pick colors out of thin air and not knowing how they look after it's on the page. https://www.color-hex.com/color/eecbcb I personally like this color for darkmode

I dont, imo. It looks rotten asf like as if it an actual bunny was mudered xd

I mean the purple is not bad if matched right with other like colors for a dark theme but ig the navbar and footer is throwing me off. Use a color palette once the main color is chosen for a dark theme.

You have a ticket up for reworking the nav and footer right?

[GrpFruit]

show her color palettes and have her choose the one she likes best, I bet its a burden for her to pick colors out of thin air and not knowing how they look after it's on the page. https://www.color-hex.com/color/eecbcb I personally like this color for darkmode

I dont, imo. It looks rotten asf like as if it an actual bunny was mudered xd

I mean the purple is not bad if matched right with other like colors for a dark theme but ig the navbar and footer is throwing me off. Use a color palette once the main color is chosen for a dark theme.

You have a ticket up for reworking the nav and footer right?

also maybe try changing the scroll bar to dark mode too to see what it looks like. If it ain't funk Shuai change it back xD

[jmorales8]

show her color palettes and have her choose the one she likes best, I bet its a burden for her to pick colors out of thin air and not knowing how they look after it's on the page. https://www.color-hex.com/color/eecbcb I personally like this color for darkmode

I dont, imo. It looks rotten asf like as if it an actual bunny was mudered xd

I mean the purple is not bad if matched right with other like colors for a dark theme but ig the navbar and footer is throwing me off. Use a color palette once the main color is chosen for a dark theme.

You have a ticket up for reworking the nav and footer right?

yea but mainly the footer, i can make one for the footer if you want