search

jmorrell / backbone-filtered-collection

Create a filtered version of a backbone collection that stays in sync.
MIT License
63 stars 9 forks source link

Not instanceof Backbone.Collection #10

Open ben-ng opened 9 years ago

ben-ng commented 9 years ago

This module is incompatible with code that checks for obj instanceof Backbone.Collection. Is there a reason why these collections aren't simply extended from Backbone.Collection?

jmorrell commented 9 years ago

If you use Obscura directly, it would pass https://github.com/jmorrell/backbone.obscura/blob/master/index.js#L129 but it was too much work to repeat it for all of the sub-collections.

I originally split this into 4 modules, but today I'd keep it as only one since they ended up being pretty coupled in the end. Changes to any of them required rebuilding all of the higher dependencies, and too many of the changes needed to apply to all of them, leading to too much thrash. I'd also love to get rid of the three different types of subcollections and just do a diff against the previous state, but since I don't use these modules myself anymore there's not a lot of motivation to do that work.