jmorton06 / Lumos

Cross-Platform C++ 2D/3D game engine
MIT License
1.21k stars 130 forks source link

Improved Windows Generation & Build Scripts #125

Closed adriengivry closed 7 months ago

adriengivry commented 7 months ago

Describe the issue (if no issue has been made)

Windows build scripts in Scripts/Windows currently do not work when executed by double-clicking on them. MSBuild location is also tied to a specific version of VS (Community).

Changelist

Additional context

Tested changes by running: ✅ GenerateVS17.batGenerateVS19.batGenerateVS22.bat And building the runtime and editor using: ✅ BuildWindows.batBuildWindows-Editor.bat

Test machine info:

Processor   AMD Ryzen 9 3900X 12-Core Processor 3.80 GHz
Installed RAM   64.0 GB
Edition Windows 11 Pro
Version     23H2
OS build    22631.2792
Experience  Windows Feature Experience Pack 1000.22681.1000.0
MSBuild     17.8.3+195e7f5a3 for .NET Framework

vswhere.exe version: https://github.com/microsoft/vswhere/releases/tag/3.1.7

jmorton06 commented 7 months ago

Nice! Thank you