jmpate / ot-cmp-gcm-template

OneTrust CMP Template
Apache License 2.0
2 stars 4 forks source link

Update template.tpl #3

Closed simonmadsen closed 2 years ago

simonmadsen commented 2 years ago

it seems https://cookie-cdn.1trust.app/* was used as injection url before I assume since it was in this code, but now the injection url must be https://cdn.cookielaw.org/ be aware that no wildcard is needed at the end, at least for tag manager templates because if the page path is just / then it is already seen wildcard after that tested and working with the mentioned change. not working without it currently

simonmadsen commented 2 years ago

let me know when you have reviewed the change so we can have this implemented

simonmadsen commented 2 years ago

@jmpate how about letting this pull request go through? because the url you use right now makes the onetrust cmp template not work at all! until you fix more things as mentioned yesterday (cc @twslade)

simonmadsen commented 2 years ago

@jmpate funny thing, i asked onetrust about https://cookie-cdn.1trust.app/ and they say it never was theirs? maybe their support is just wrong

jmpate commented 2 years ago

Hey @simonmadsen I am the Product Manager for OneTrust Cookie Consent. I can confirm this src URL is from our dev environment. It is one of ours and was not updated properly after testing to the prod src URL.

simonmadsen commented 2 years ago

Hey @simonmadsen I am the Product Manager for OneTrust Cookie Consent. I can confirm this src URL is from our dev environment. It is one of ours and was not updated properly after testing to the prod src URL.

ok makes sense it didnt work then the one i suggested is the correct one right?

when do you plan @jmpate to implement the suggestions by @twslade? so that the template can work out of the box with tag manager tags that support consent? currently google analytics and google ads at least

jmpate commented 2 years ago

Correct, cdn.cookielaw is our prod URL

Expect updates by next week. With the updates, associations with OneTrust categories and updates to consent storages will be possible from the template.

simonmadsen commented 2 years ago

ciations with

great! @jmpate @twslade