search

jmpcn / openid4java

Automatically exported from code.google.com/p/openid4java
Apache License 2.0
0 stars 0 forks source link

Warnings cleanup #146

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
Hi, here is a patch to get rid of over 500 warnings in openid4java. It is 
applicable to SVN revision 659.
Most of the changes involve generic collections, foreach, annotations and 
varargs.

The code is compatible with java 6; if you need java 5 compatibility then I can 
modify it (but the differences should be trivial).
I excluded a bunch of classes that I don't use; I haven't touched those.
I haven't fixed any serializable class without serialVersionUID.
I also haven't removed unnecessary declarations of thrown exceptions, except in 
SampleConsumer.

To the best of my knowledge, the changes don't affect the functionality in any 
way. It might cause some compile errors in the classes I excluded (due to the 
use of generics), but they should be trivial to fix.

Original issue reported on code.google.com by adi...@gmail.com on 25 Mar 2011 at 6:04

Attachments:

GoogleCodeExporter commented 8 years ago 
I wonder why a library that has been started by end of 2006 does not at least 
use generics, which were introduced with Java 5 in 2004? :-( That's a 
dealbreaker for me.

Original comment by sj1...@gmail.com on 20 Jul 2013 at 12:20