search

jmplonka / InventorLoader

Workbench for FreeCAD to loads or import Autodesk (R) Inventor (R) files.
GNU General Public License v2.0
114 stars 17 forks source link

Remove dependency on xlutils and instead embed a small extract of the library code #78

Open hlovdal opened 1 year ago

hlovdal commented 1 year ago

This fixes the issue (#62) with depending on an unmaintained/deprecated library.

InventorLoader only uses the copy function from xlutils, and extracting the required code is just 500 lines.

marcocecchiscmgroup commented 11 months ago

Xlutils seems to be a dependency of FreeCAD as well.

FreeCAD Dependency Study](https://forum.freecad.org/viewtopic.php?style=4&t=77910)

So this embedding I quite don't like. How do they manage this deprecation issue in FreeCAD?

pawsen commented 7 months ago

Xlutils seems to be a dependency of FreeCAD as well.

FreeCAD Dependency Study](https://forum.freecad.org/viewtopic.php?style=4&t=77910)

So this embedding I quite don't like. How do they manage this deprecation issue in FreeCAD?

I understand the post as: FreeCAD sets up a python env using Conda, where xlutils are on of the packages available in the env. It does not mean that freecad depends on xlutils. See also freecad repo

It would be nice if InventorLoader dropped dependency on xlutils. I think this is a nice solution.