search

jmprathab / MyHome

A Java application which helps people to manage their apartment.
Apache License 2.0
93 stars 107 forks source link

Endpoint for booking an amenity #113

Open jmprathab opened 4 years ago

jmprathab commented 4 years ago

⚠️ Is your feature request related to a problem? Please describe

💡 Describe the solution you'd like

Task Relationship

Subtask of: jmprathab/MyHome#94

zhupanovdm commented 4 years ago

@jmprathab Hello, I'm new in open source, can I take this task?

jmprathab commented 4 years ago

@zhupanovdm Sure. Request you to comment on your approach before implementing.

mslowiak commented 4 years ago

@zhupanovdm Any update from you?

zhupanovdm commented 4 years ago

Hi. Sorry for silence. There was a lack of spare time. But now I'm in.

mslowiak commented 4 years ago

@zhupanovdm How it is going?

mslowiak commented 4 years ago

It has been 9 days since last update, task is still up for grabs :)

tomsajuk commented 4 years ago

Shall I take this up?

tomsajuk commented 4 years ago

Hi @jmprathab had some queries regarding the issue. Posting it below:

  1. Should a user be able to book an amenity for another user? (neighbours maybe)
  2. Any restrictions on the number of bookings and people at a particular time-slot? (There would be rush during weekends)
  3. Can assume that the user can only book an amenity available in his community? (Would be throwing error if outside the community, so what error should I throw?)
  4. Whats the purpose of the 'price' attribute in the Amenity domain? Should the user be paying at the time of booking or its a membership fee?

If you could answer these queries would help a lot in the implementation. :) If you add your thinking that would also be good.

jmprathab commented 4 years ago

Hi @jmprathab had some queries regarding the issue. Posting it below:

  1. Should a user be able to book an amenity for another user? (neighbours maybe)
  2. Any restrictions on the number of bookings and people at a particular time-slot? (There would be rush during weekends)
  3. Can assume that the user can only book an amenity available in his community? (Would be throwing error if outside the community, so what error should I throw?)
  4. Whats the purpose of the 'price' attribute in the Amenity domain? Should the user be paying at the time of booking or its a membership fee?

If you could answer these queries would help a lot in the implementation. :) If you add your thinking that would also be good.

Great thoughts BTW.

  1. Let's not do this.
  2. Yes. Booking overlap should be restricted.
  3. HTTP 403 can be returned in case. Note: Implementation has to use AuthorizationFilter rather than having the logic in the controller. master has similar implementations already.
  4. User is not expected to pay for the amenity while booking. The idea is, CommunityAdmin might be able to generate a payment for a particular user for using an amenity.
douglas-oliveira-talkdesk commented 4 years ago

@tomsajuk Are you working into this task? If not, can I please get it? Thanks 👍

tomsajuk commented 4 years ago

@douglas-oliveira-talkdesk sure you can go ahead. Not getting time to work on this. @jmprathab assign it to him please

DDmit04 commented 3 years ago

can I take this?

mslowiak commented 3 years ago

@DDmit04 yes ;)

jfjara commented 3 years ago

Hello, Could I take this? Regards

bayotheman commented 2 years ago

Hi @mslowiak @jmprathab could I take this task?

bayotheman commented 2 years ago

Hi @mslowiak @jmprathab just another reminder, could I take this task?

alexniko44 commented 1 year ago

is this task up for grabs?

aman-junaid commented 1 year ago

Hi @mslowiak, @jmprathab,

Is anyone working on this?? or its up for Grabs?

cjhier commented 8 months ago

Hi @mslowiak, @jmprathab,

Is this up for grabs? I'd like to look into it.