jmprathab / MyHome

A Java application which helps people to manage their apartment.
Apache License 2.0
92 stars 106 forks source link

Issue #224: Divide postman collection into directories #248

Closed JanneSickert closed 3 years ago

JanneSickert commented 3 years ago
                    "url": {
                        "raw": "http://{{ENV_URL}}/auth/login",          <-- change here
                        "protocol": "http",
                        "host": [
                            "{{ENV_URL}}"
                        ],
                        "path": [
                            "auth",                                                      <-- change here
                            "login"
                        ]
                    }

Next time I write in the original file then you can see the changes.

codecov[bot] commented 3 years ago

Codecov Report

Merging #248 (f18b103) into master (ad8669e) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #248   +/-   ##
=========================================
  Coverage     68.28%   68.28%           
  Complexity      200      200           
=========================================
  Files            34       34           
  Lines           864      864           
  Branches         41       41           
=========================================
  Hits            590      590           
  Misses          266      266           
  Partials          8        8           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ad8669e...f18b103. Read the comment docs.

mslowiak commented 3 years ago

Thank you for working with that @JanneSickert!

Would you mind replacing the original file with the new one that you made? We want to have just one postman collection in the repository.

It looks good however we have some contribution guideline and would be great if you can fix two things:

The patterns for commit message and pull request name are described here

JanneSickert commented 3 years ago

The name for the commit is only saved on my computer. Do you know the broblem? And thank you for creating such issues where I can learn to use github.

mslowiak commented 3 years ago

@JanneSickert I messaged you via discord