Issue #243: add unit tests for AuthenticationController, AuthenticationSDJpaService, UserSDJpaService (method findUserByEmail)

[hsergiu]

🚀 Description

Created multiple tests for each method. Only a single one for login() in AuthenticationController.

📄 Motivation and Context

Closes: #243

📦 Types of changes

• [ ] Bug fix (non-breaking change which fixes an issue)
• [x] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

✅ Checklist

• [x] My code follows the code style of this project(Do your best to follow code styles. If none apply just skip this).
• [ ] My change requires a change to the documentation.
• [ ] I have updated the documentation accordingly.

[codecov[bot]]

Codecov Report

Merging #251 (b7adca1) into master (f7ec6a4) will increase coverage by 5.07%. The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #251      +/-   ##
============================================
+ Coverage     68.28%   73.36%   +5.07%     
- Complexity      200      217      +17     
============================================
  Files            34       34              
  Lines           864      871       +7     
  Branches         41       41              
============================================
+ Hits            590      639      +49     
+ Misses          266      224      -42     
  Partials          8        8              

Impacted Files	Coverage Δ	Complexity Δ
...ices/springdatajpa/AuthenticationSDJpaService.java	100.00% <100.00%> (+100.00%)	7.00 <1.00> (+7.00)
...yhome/services/springdatajpa/UserSDJpaService.java	86.90% <0.00%> (+9.52%)	29.00% <0.00%> (+2.00%)
...m/myhome/controllers/AuthenticationController.java	100.00% <0.00%> (+100.00%)	2.00% <0.00%> (+2.00%)
.../controllers/exceptions/UserNotFoundException.java	100.00% <0.00%> (+100.00%)	2.00% <0.00%> (+2.00%)
...ontrollers/exceptions/AuthenticationException.java	100.00% <0.00%> (+100.00%)	2.00% <0.00%> (+2.00%)
...lers/exceptions/CredentialsIncorrectException.java	100.00% <0.00%> (+100.00%)	2.00% <0.00%> (+2.00%)

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f7ec6a4...b7adca1. Read the comment docs.

[mslowiak]

@hsergiu Just one more comment about this PR and we can proceed with merge :)

[hsergiu]

Thank you for the review. I made the changes.