jmprathab / MyHome

A Java application which helps people to manage their apartment.
Apache License 2.0
92 stars 106 forks source link

Issue #233: Move endpoints related to amenities from community tag #253

Closed JanneSickert closed 3 years ago

JanneSickert commented 3 years ago

Closes: #233

codecov[bot] commented 3 years ago

Codecov Report

Merging #253 (39faff4) into master (f7ec6a4) will not change coverage. The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #253   +/-   ##
=========================================
  Coverage     68.28%   68.28%           
  Complexity      200      200           
=========================================
  Files            34       34           
  Lines           864      864           
  Branches         41       41           
=========================================
  Hits            590      590           
  Misses          266      266           
  Partials          8        8           
Impacted Files Coverage Δ Complexity Δ
...va/com/myhome/controllers/CommunityController.java 98.90% <ø> (+3.95%) 31.00 <0.00> (-2.00) :arrow_up:
...java/com/myhome/controllers/AmenityController.java 85.18% <50.00%> (-14.82%) 10.00 <2.00> (+2.00) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f7ec6a4...24e1060. Read the comment docs.

mslowiak commented 3 years ago

@JanneSickert How is it going?

JanneSickert commented 3 years ago

I had also copyed two methods depending from the

@InjectMocks private AmenityController amenityController;

I executed

and it had build without any errors. If it was right to move the methods, I only must running Code Style and can rise a PR.

JanneSickert commented 3 years ago

Oh, I mean rise a commit :)