search

jmpressjs / jmpress.js

A jQuery plugin to build a website on the infinite canvas
http://jmpressjs.github.com/jmpress.js
1.5k stars 237 forks source link

Consistent code style #168

Closed FagnerMartinsBrack closed 9 years ago

FagnerMartinsBrack commented 9 years ago

This project's code base does not seems to have a consistent code style. Since this is a jquery plugin I would suggest to adhere to the jQuery Core Style Guidelines and enforce it using grunt jscs plugin

FagnerMartinsBrack commented 9 years ago

@shama

So am I good to send a pull request on this?

shama commented 9 years ago

Feel free to send a PR if you want to. I'm not really bothered by the code style so it's not a high priority for me. :)

FagnerMartinsBrack commented 9 years ago

Consistency is important if you want to concentrate in code instead of style issues, I mean regarding contributions. I will send a PR using jquery core style guidelines.

shama commented 9 years ago

I'll explain why it's not a priority for me. 97.5% of the contributions are @sokra and I (a common distribution with open source projects). I am more concerned about making the highest contributors comfortable than enforcing someone else's code style.

Especially because the test coverage isn't great here and these kinds of commits usually introduce bugs. As well as mess with the git blame.

But feel free to send a PR. I just think there are more interesting problems to solve instead. ;)

FagnerMartinsBrack commented 9 years ago

I understand your point. In that case it would be interesting not to enforce code styles for ci and correct them manually for new code if necessary.

I will setup a PR for you to take a look.

shama commented 9 years ago

Closing because https://github.com/jmpressjs/jmpress.js/pull/171#issuecomment-69217659