jmpressjs / jmpress.js

A jQuery plugin to build a website on the infinite canvas
http://jmpressjs.github.com/jmpress.js
1.5k stars 237 forks source link

npm out of sync with latest code #187

Open patorjk opened 8 years ago

patorjk commented 8 years ago

I installed this library with npm and noticed the transitions between slides didn't work in Chrome or FireFox (but they did work in Safari - I was on a Mac when doing my testing). I did some digging and found this thread:

https://github.com/jmpressjs/jmpress.js/issues/154

In there the issue is fixed with this pull request:

https://github.com/omervk/jmpress.js/commit/5c1ee86685b16461a42ed5bf575f7d90d5522e69

I checked the library I got from npm and it didn't have those updates. I looked at the code in this repo and it seems to have those updates. I added them in and now transitions between slides seem to work. Another side note, I don't see any slide transitions when I look at your official demo:

http://jmpressjs.github.io/jmpress.js/

It's version of the code seems to match what's in npm.