search

jmptbl / python-zint

Python ctypes interface to libzint
BSD 3-Clause "New" or "Revised" License
6 stars 7 forks source link

PEP8 (& Python3) #2

Closed Cabalist closed 5 years ago

Cabalist commented 6 years ago

Hey there,

Thank you for this project it really saved me during a warehouse emergency last night. I did some mild cleanup to the code. Should have no functionality changes but just make it more PEP8-y....

I really like the way you wrote the fields declarations. So simple and I've seen such ugly implementations using new().

Cabalist commented 6 years ago

I added one more commit to make the README examples Python3 compatible. The code itself works great in Python3 as long as you pass a bytes instead of a str. The examples still work in Python2 as well.

jmptbl commented 5 years ago

Since your PR contains a mix of changes that I like and dislike, I think it'll be easiest if I commit the parts that I like separately myself. Again, your contribution is greatly appreciated!