kill() does not fire close event

[binarykitchen]

Been debugging a case where the grunt task never quit. It hang forever.

I found out that on line https://github.com/jmreidy/grunt-mocha-webdriver/blob/master/tasks/grunt-mocha-wd.js#L100 the kill() command did never fire the close event on the line https://github.com/jmreidy/grunt-mocha-webdriver/blob/master/tasks/grunt-mocha-wd.js#L96

This made the grunt task hang forever. No idea why the phantom child process is never closed. Looks like a bug ...

[binarykitchen]

Okay, I found the cause, see comment https://github.com/jmreidy/grunt-mocha-webdriver/issues/60#issuecomment-42920886

Make sure you test if the PhantomJS process is already killed. If so, either fire the close event manually or run the functions inside the close listener.

[jmreidy]

Is this fixed by #68?

[binarykitchen]

yep