search

jmreyes / passport-google-id-token

Google ID token authentication strategy for Passport and Node.js.
MIT License
44 stars 22 forks source link

tweaked strategy.js to check if the token is already expired #9

Closed rakesh1988 closed 8 years ago

rakesh1988 commented 8 years ago

Hi, I have added another condition to check if the JWT is already expired. If you feel this check is required, please accept my pull request.

kvchen commented 8 years ago

The jsonwebtoken module already checks if the token is expired when calling verify.

jmreyes commented 8 years ago

Hi Rakesh. First of all, thanks for this. However, as kvchen mentioned, the check is already performed by the jsonwebtoken module we are leveraging, so there's no need for further checks here. But this made me realize that maybe some comments about this fact would be of use, I guess I'll add them for clarification.