jmriego / emulation

0 stars 0 forks source link

Steam Games Error #5

Closed TonyBirt closed 4 years ago

TonyBirt commented 4 years ago

Hi Jmriego

I made some folder/file changes in Windows and have disturbed something in AEL. When running Steam games in Kodi, I get the error Windows cannot find '-- steam://rungameid/710920 etc.. I can change the arguments in Kodi and take out the -- on a per game basis and they will work, but when executing launchbox2ael.py the -- comes back in the Arguments.

Thanks Tony

jmriego commented 4 years ago

The -- should be needed for running Steam games unless there have been some change in the Steam command line I haven't received the update for. The way this works is that the script will go to the Registry and check Steam\Shell\Open\Command to learn what are the parameters to run a Steam game in your computer. I'm not sure yet what's happening here.

Can you send me about that game what's the "altapp", "altarg" and "filename" that you are getting in your Json file?

TonyBirt commented 4 years ago

Thank you for looking into it.

"altapp": "C:\Program Files (x86)\Steam\Steam.exe", "altarg": "-- steam://rungameid/710920", "filename": ".",

jmriego commented 4 years ago

no problem at all. Can you open a command line window and run this command? "C:\Program Files (x86)\Steam\Steam.exe" -- steam://rungameid/710920

I guess that's going to work, but this wouldn't: "C:\Program Files (x86)\Steam\Steam.exe" "-- steam://rungameid/710920"

If that's the case, can you let me know which AEL version you are using?

TonyBirt commented 4 years ago

Correct, the first command works only, Running version 0.9.9

jmriego commented 4 years ago

I'm having issues trying to reproduce this in my system. I have exactly the same version and similar information for the Steam games but it works for me. But the error you get is clearly that is not finding that file which is strange as it should be calling Steam.exe.

The only idea I have at the moment for continuing figuring this out is if you could send me part of the kodi.log where it's failing. Maybe that way I can find exactly why AEL is not running the command I thought it would run with those parameters you sent me earlier

TonyBirt commented 4 years ago

2020-07-03 08:35:57.977 T:14128 ERROR: AEL INFO : _command_run_rom() Launching ROM in Launcher ... 2020-07-03 08:35:57.981 T:14128 ERROR: AEL INFO : _command_run_rom() Using ROM altapp/altarg 2020-07-03 08:35:57.982 T:14128 ERROR: AEL INFO : _command_run_rom() Sigle ROM detected (no multidisc) 2020-07-03 08:35:57.982 T:14128 ERROR: AEL INFO : _command_run_rom() ROMFileName OP "." 2020-07-03 08:35:57.982 T:14128 ERROR: AEL INFO : _command_run_rom() ROMFileName P "." 2020-07-03 08:35:57.982 T:14128 ERROR: AEL INFO : _command_run_rom() categoryID 45888a4da062f16a099a7f7c6cc15ee0 2020-07-03 08:35:57.982 T:14128 ERROR: AEL INFO : _command_run_rom() launcherID 1105b975d2715fd81a992874a392a168 2020-07-03 08:35:57.982 T:14128 ERROR: AEL INFO : _command_run_rom() romID 5677879c-7e34-436d-a551-e051172991e1 2020-07-03 08:35:57.982 T:14128 ERROR: AEL INFO : _command_run_rom() romfile "." 2020-07-03 08:35:57.982 T:14128 ERROR: AEL INFO : _command_run_rom() rompath "" 2020-07-03 08:35:57.982 T:14128 ERROR: AEL INFO : _command_run_rom() rombase "." 2020-07-03 08:35:57.982 T:14128 ERROR: AEL INFO : _command_run_rom() rombasenoext "." 2020-07-03 08:35:57.982 T:14128 ERROR: AEL INFO : _command_run_rom() romtitle "Castle of Illusion Starring Mickey Mouse" 2020-07-03 08:35:57.982 T:14128 ERROR: AEL INFO : _command_run_rom() application "C:\Program Files (x86)\Steam\steam.exe" 2020-07-03 08:35:57.982 T:14128 ERROR: AEL INFO : _command_run_rom() apppath "C:\Program Files (x86)\Steam" 2020-07-03 08:35:57.982 T:14128 ERROR: AEL INFO : _command_run_rom() romext "lnk" 2020-07-03 08:35:57.982 T:14128 ERROR: AEL INFO : Launching app found "C:\Program Files (x86)\Steam\steam.exe" 2020-07-03 08:35:57.982 T:14128 ERROR: AEL INFO : ROM found "." 2020-07-03 08:35:57.982 T:14128 ERROR: AEL INFO : _command_run_rom() raw arguments "-- steam://rungameid/227600" 2020-07-03 08:35:57.982 T:14128 ERROR: AEL INFO : _command_run_rom() final arguments "-- steam://rungameid/227600" 2020-07-03 08:35:58.001 T:14128 ERROR: AEL INFO : fs_write_Favourites_JSON() File special://profile/addon_data\plugin.program.advanced.emulator.launcher\most_played.json 2020-07-03 08:35:58.016 T:14128 ERROR: AEL INFO : _command_run_rom() Launcher is not Kodi Retroplayer.

TonyBirt commented 4 years ago

I was trying to fix folder permissions and ran this command before I started to have the issues, this may have altered registry? 1) launch powershell 2) Set-ExecutionPolicy Unrestricted 3) Get-AppXPackage -AllUsers | Foreach {Add-AppxPackage -DisableDevelopmentMode -Register "$($_.InstallLocation)\AppXManifest.xml"}

jmriego commented 4 years ago

It's really strange you are finding this. All of that don't look strange to me. Is that the whole part of the log related to the issue? It's strange that it doesn't really return the "windows can't find this file" message or similar

Also, if you could send me not only "altapp", "altarg" and "filename" but the whole info for the game that might help investigating it

TonyBirt commented 4 years ago

kodi.log Not sure which part to upload so pasted whole log, apologies for the trouble. I have got around issue by replacing instances of --steam with steam in Notepad+, so it is still working good, thanks.

jmriego commented 4 years ago

no worries! I think I found the issue and it seems like AEL is a bit picky when having a launcher that mixes Windows .exe games with .lnk and steam ids. The fix I just uploaded should account for it Let me know if it's solved for you

TonyBirt commented 4 years ago

That works :) Put through a donation, thanks.

jmriego commented 4 years ago

oh thanks a lot! :) by the way, I also added a new feature for collections. If you have any playlists in LaunchBox they should appear as collections in AEL