search

jmrivas86 / django-json-widget

An alternative widget that makes it easy to edit the new Django's field JSONField (PostgreSQL specific model fields)
MIT License
440 stars 88 forks source link

Remove source map reference from JS bundle #70

Closed stefanw closed 1 year ago

stefanw commented 2 years ago

Starting in Django 4 the manifest static file storage will try to post process source map references. The source map is not available in this app which will lead to an error when running manage.py collectstatic. Removing the reference clears the error.

See https://docs.djangoproject.com/en/4.0/ref/contrib/staticfiles/#manifeststaticfilesstorage

fabiocaccamo commented 1 year ago

This PR solves #63. (just for reference in the issue)

dgorobets commented 1 year ago

Any update on this?

StevenMapes commented 1 year ago

I messaged José on Twitter and he's going to look to update the project next month as he's really busy at the moment it seems, so hopefully before the end of June there'll be an updated release on pypi with this update as well as the other three PRs that have come in at the very least :)

bmull commented 1 year ago

Can we please merge this?

theognis1002 commented 1 year ago

Please merge! @StevenMapes

StevenMapes commented 1 year ago

Please merge! @StevenMapes

I do not have permission to perform merges you'll need to contact @jmrivas86

StevenMapes commented 11 months ago

@jmrivas86 - could you publish a new version to pypi please

davidemerritt commented 10 months ago

+1 can this get published, it blocks django 4.x upgrade

ekaj2 commented 10 months ago

In the interim, you can use this in your requirements.in:

# remove the pypi dep
# django-json-widget==1.1.1

# reference this w/ GitHub and pin the commit hash where this was merged
git+https://github.com/jmrivas86/django-json-widget.git@6141d61#egg=django-json-widget
sowinski commented 8 months ago

Please publish a new version :)

sowinski commented 8 months ago 
6141d61

For me this did not work. Are you sure about the correct commit tag?

ekaj2 commented 8 months ago

Yup that's what we use, but use any commit/branch you want: https://github.com/jmrivas86/django-json-widget/commits/master/

Format is slightly different depending on your pip tool though, so read the documentation if you don't just use vanilla pip

sowinski commented 8 months ago

Yup that's what we use, but use any commit/branch you want: https://github.com/jmrivas86/django-json-widget/commits/master/

Format is slightly different depending on your pip tool though, so read the documentation if you don't just use vanilla pip

I used the latest commit and it works.

git+https://github.com/jmrivas86/django-json-widget.git@32c6acf#egg=django-json-widget

What is the difference here? Do you know it?