search

jmrossy / celo-web-wallet

Othello: A lightweight, self-sovereign wallet for the Celo network. Runs on the web and on desktop.
https://celowallet.app
MIT License
45 stars 28 forks source link

isSecretTooSimple fails for passwords longer than 32 characters #35

Closed aaronmgdr closed 3 years ago

aaronmgdr commented 3 years ago

isSecretTooSimple fails for passwords longer than 32 characters

this results in a misleading message in ui of "password is too simple" when in fact it is too long

https://github.com/celo-tools/celo-web-wallet/blob/e61ce1589bdcbe6d1c7773f2f96e4735600b9323/src/features/pincode/utils.ts#L20

jmrossy commented 3 years ago

Good catch, thanks @aaronmgdr! Should be an easy fix

jmrossy commented 3 years ago

I have some improvements to the password handling coming with the next update. It adds support up to 100 chars, adds helpful error messages for the various requirements, and adds a password strength bar :)

jmrossy commented 3 years ago

The improvements are now live in 1.2.0 😄