Add zoom functionality for linux and windows

jmrossy / celo-web-wallet

Othello: A lightweight, self-sovereign wallet for the Celo network. Runs on the web and on desktop.

https://celowallet.app

MIT License

45 stars 28 forks source link

Add zoom functionality for linux and windows #81

Closed kamiyaa closed 2 years ago

kamiyaa commented 2 years ago

Fixes https://github.com/celo-tools/celo-web-wallet/issues/80

jmrossy commented 2 years ago

@kamiyaa Thanks for the PR, looks good! I'm semi-offline atm for holidays but I'll test it in a few days and ship it with the next release.

kamiyaa commented 2 years ago

@jmrossy no problem! Happy holidays!

jmrossy commented 2 years ago

@kamiyaa I tested this today on MacOS and found it has no effect. I suspect this code needs to execute in the renderer process, not the main.js electron one. See here.

Also I'm not sure any changes are needed because zooming does work via command + / - or through the menu. Maybe it's different on Windows, is that where you tested?

jmrossy commented 2 years ago

Ah I think this answers my question. MacOS is different: https://github.com/electron/electron/pull/17747/files#diff-675d2fdc497df732c76f0d75423e72331a9ffbb4d5c71d9ef792bd209b6edb70R350

I can test on Windows soon.

kamiyaa commented 2 years ago

Oh I see. I was testing on Linux. Also, I just found out you can scale electron apps via --force-device-scale-factor=1.5 :eyes: