jmrozanec / cron-utils

Cron utils for parsing, validations and human readable descriptions as well as date/time interoperability.
http://cron-utils.com
Apache License 2.0
1.14k stars 262 forks source link

Change resource locations #531

Closed J0B10 closed 2 years ago

J0B10 commented 2 years ago

Our project uses maven shade plugin to shade cron-utils into our release jar.

When doing so, a lot of resources of cron-utils end up in the root directory of the jar:

grafik

Therefore I'dd like to propose the following changes:

  1. Move the checkstyle.xml to a config folder, as it is not a resource of the code and is not needed in released artifacts.
  2. Move the resource bundle to com.cronutils package, so you can easily see where they belong to and are able to relocate them when shading cron-utils into your project.

Also I changed it translation from CRLF to LF line breaks.

jmrozanec commented 2 years ago

@J0B10 makes sense! Merged! Thanks! 😄