jmsandiegoo / pe

0 stars 0 forks source link

unable to find for a particular book in the library #7

Open jmsandiegoo opened 1 month ago

jmsandiegoo commented 1 month ago

Steps to Reproduce

  1. Add a book addbook b/test
  2. enter find b/test

Expected Behavior

The application being a library management app it should allow user to quickly search for a book.

Actual Behavior

The application currently does not support such functionality which is crucial for large libraries

nus-se-bot commented 1 month ago

Team's Response

Thank you for the bug report.

After careful consideration my team has decided that this issue is not within the scope of our current project.

As of now, it is stated in our user guide that the find function is specifically to search for library users.

image.png

As such typing find b/ is actually an incorrect format.

Our application is not meant to be a general all-encompassing library management application, but we specifically are handling management of library user contacts and their ability to borrow. As such, as of this iteration, there is no need to have find also search for books. The purpose of find is to get back an index for the use within commands. However, our current iteration of commands utilises the the full book title instead of the index of the book, hence searching for a index is not a needed feature yet.

We do agree that using implementing a BOOK_INDEX will eventually help speed up the process, and hence we plan for it to be added in a future iteration such as v1.5:

image.png

However, integrating a BOOK_INDEX requires us to rework the previous commands and possibly create even more functions than just a singular findbook as the manager might want to find a book in a library or find a book in the library user's borrowed books list.

As such we have decided to consider it as NotInScope as this is not essential to the functionality of our application but does require us to spend a large amount of effort in reworking the current commands to integrate a BOOK_INDEX before any benefits can be seen by the end user as per the guidelines below:

image.png

Note: While response.NotInScope are not counted against the dev team, they can earn a small amount of consolation marks for the tester. The other three do not affect marks of either the dev team or the tester.

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]