jmschrei / pomegranate

Fast, flexible and easy to use probabilistic modelling in Python.
http://pomegranate.readthedocs.org/en/latest/
MIT License
3.35k stars 589 forks source link

Added Half-Normal & Log-Normal Distributions #1063

Closed mschrader15 closed 2 months ago

mschrader15 commented 1 year ago

I had a use case for a mixture model of half-normal & lognormal distributions. I did a quick implementation by sub-classing the normal distribution.

Missing tests, but this suffices for my use-case

jmschrei commented 1 year ago

Nice, thanks. I'll look into merging this soon.

jmschrei commented 10 months ago

Sorry for the delay in approval. Would you mind adding in unit tests, of the style of the other distributions?

jmschrei commented 10 months ago

Otherwise this LGTM