Instant mix improvements

jmshrv / finamp

A Jellyfin music client for mobile

Mozilla Public License 2.0

1.69k stars 120 forks source link

Instant mix improvements #271

Open foss- opened 2 years ago

foss- commented 2 years ago

LineageOS 12 2022-07-11 FinAmp 0.6.4

On Jellyfin web there is a compass icon for Instant Mix. The 0.6.4 release notes list Instant mix with albums (@faizzzzz) however when in 0.6.4 and on an album there is no compass icon. Tapping a title, player will open but also there is no compass icon to be found. Not quite sure, how instant mix with albums is supposed to work.

Sidenote: Tapping album or artist works great and is a very useful addition which I love!

PS: Should 0.6.4 be tagged as release (and not pre-release)?

rom4nik commented 2 years ago

You can long press albums on albums tab to add them to mix, then press the hover button in bottom right corner to start. The mix behavior doesn't seem in line with web client anyway, on web you don't need to preselect albums to include in mix, and you'll get other albums from library included in mix (like with Instant Mix for songs, where web and Finamp's behavior is similar).

foss- commented 2 years ago

Right, would you consider the current behavior in FinAmp expected or unexpected? I was expecting it to be inline with web. Will have to use the new / different behavior in FinAmp for a while to better understand it.

rom4nik commented 2 years ago

Me too, since I use the web client for music on PC I try to (where feasible) follow its design and behavior in my PRs for Finamp. This one obviously isn't mine though. @faizzzzz

faizzzzz commented 2 years ago

My approach was more inline with the Plexamp's Mix Builder feature, in which you mix only the selected albums.

foss- commented 1 year ago

After thinking about this, I think I oppose the current implementation. Let me explain why and as I am not sure I understand current behavior here is what I think it does:

Users add a few albums to Instant Mix and when they then tap on the instant mix icon, those items are shuffled. Hope this is correct.

To me this makes using Instant Mix unnecessarily complex.

Expected

Click on instant mix to have similar artists / songs played like a radio station (like it works in Jellyfin web). That is easy, intuitive and quick to use.

Currently

The current behavior feels like a playlist that is shuffled. And the question I want to ask is, why not use a playlist and shuffle that, if that is the functionality you are looking for? It feels as if expected behavior is deviated, but I am not sure why.

Disclaimer: I am not familiar with PlexAmp since that is a payed only feature and I have no access to that.

Chaphasilor commented 9 months ago

I think we should change this to behave like the following:

In the album list, you can long-press and then select "Album mix" to start a mix for just this album
On an album page (for a single album, e.g. by tapping an album inside the album list) you get an additional button for starting an instant mix for that album. So in total you have three playback options, play, shuffle, and instant mix, where instant mix is a bit less limited than just shuffle in that it can include similar tracks that are not within this album
On the album list, you still have the floating button in the bottom right corner (or something equivalent). Clicking the button will open a mix builder screen where you can select a bunch of albums that should make up the mix, like it seems to work in Plexamp

Let me know what you guys think!

jmshrv commented 9 months ago

That sounds good :)