search

jmshrv / finamp

A Jellyfin music client for mobile
Mozilla Public License 2.0
1.89k stars 124 forks source link

"Add to Playlist" allows for duplicates #438

Open Emporea opened 1 year ago

Emporea commented 1 year ago

Adding a song to a playlist that is already present in the playlist adds it another time.

finamp: 0.6.12 fdroid jellyfin. 10.8.9

Playlists and Jellyfin is a weird topic in general. But Jellyfin WebUI doesn't add an existing song again to a playlist nor prompts the user tho.... And having duplicates through finamp doesn't seem to bother Jellyfin.

So it would be nice to not add duplicates via finamp. If its too difficult to add a toast its also fine if it just silently doesn't add songs another time ( like Jellyfin web ui does... )

jmshrv commented 1 year ago

I'd say this is intended behaviour, other apps like Spotify let you have duplicates in playlists

Chaphasilor commented 1 year ago

I agree, but a confirmation prompt would be nice to have, because otherwise there's no way to know if a song is already in a playlist or not...

Emporea commented 1 year ago

Yes. Of course I am also for having duplicates. But I also support having a confirmation dialogue like spotify etc has.

Jellyfin unfortunately lacks this feature as well. Finmap could lead by example ;)

seniorm0ment commented 1 year ago

This could be resolved with a simple client side option users can click edit playlist and then click remove duplicates. Jellyfin does lack this server side too yes.