search

jmshrv / finamp

A Jellyfin music client for mobile
Mozilla Public License 2.0
1.96k stars 129 forks source link

AMOLED Dark Mode - A toggle in the Customisation Menu #56

Open arunk140 opened 3 years ago

arunk140 commented 3 years ago

Added this AMOLED Dark Mode Toggle in the Customisation Settings in a commit to a fork -

Link to the Commit and Some Screenshots

Let me know if it's worthy of a Pull Request.

jmshrv commented 3 years ago

Looks good, the only issue is that the theme doesn't change when the settings option is changed. Wrapping the main MaterialApp in a ValueListenableBuilder should work, but there may be more efficient ways of doing it. Also, I'd rather AMOLED mode be off by default.