[Redesign] improve integration of navigation bar on newer android versions

jmshrv / finamp

A Jellyfin music client for mobile

Mozilla Public License 2.0

1.81k stars 123 forks source link

[Redesign] improve integration of navigation bar on newer android versions #602

Open Titaniumtown opened 6 months ago

Titaniumtown commented 6 months ago

I've noticed on the redesign branch that the navigation pill is not properly integrated with the application. There's just a black space around the navigation pill, ideally it should be more integrated with the content on the screen. I can reproduce a similar effect when having the navigation buttons but the attached issue also showcases that and I'm too lazy :p

Seems maybe related to this? https://github.com/flutter/flutter/issues/111741

A little showcase of both the bug and my music taste: Screenshot_20240226-171749

Chaphasilor commented 6 months ago

Can confirm, but I didn't know this could be customized. I'll take a look! 😁

Titaniumtown commented 6 months ago

Thanks! I tried messing around with setting SystemUIMode and reading some of the flutter docs but I'm not that experienced with flutter.

jmshrv commented 6 months ago

and my music taste

great taste btw

Titaniumtown commented 6 months ago

and my music taste

great taste btw

Thank you!