search

jmshrv / finamp

A Jellyfin music client for mobile
Mozilla Public License 2.0
1.87k stars 123 forks source link

Renamed "Song" to "Track" in app_en.arb #724

Closed lukaslindnermusic closed 4 months ago

lukaslindnermusic commented 4 months ago

For now, I only renamed the user-facing strings.

I noticed that some variables and classes use "song" but some use "track" already, is this intentional? Maybe I will rename the variables and classes as well in the future when I got familiar enough with the language and codebase.

If I missed one of the user-facing strings or accidentally renamed a variable already, please let me know 😊

Chaphasilor commented 4 months ago

That looks good, thanks for the PR!
Everything seems to be converted correctly, I didn't spot any missing conversion nor a changed variable name.

And the mixed naming scheme for classes and widgets wasn't intentional, some were based on preference, others for historic reasons. With the newer ones I tried to use track instead of song, but wasn't totally consistent either.

The next step for now would be also renaming the variable names for the translations, including the placeholders in the actual translation string (this file), and also the string identifiers used in the code :)