search

jmshrv / finamp

A Jellyfin music client for mobile
Mozilla Public License 2.0
1.67k stars 118 forks source link

Expanded track details panel doesn't render background completely #744

Open Maxr1998 opened 1 month ago

Maxr1998 commented 1 month ago

When long pressing a track and then expanding the bottom sheet, the background doesn't cover the whole sheet and is instead black translucent.

Screenshot ![Screenshot](https://github.com/jmshrv/finamp/assets/5903699/c4e68d3c-7373-492b-8573-ded323a8d245)
Chaphasilor commented 1 month ago

This only happens when not on the player screen. The playlist actions menu is also affected.

Chaphasilor commented 1 month ago

@Komodo5197 I guess this broke when switching to using the generic menu. Mind taking a look?

Komodo5197 commented 1 month ago

This is most likely related to the CachePaint widget not redrawing with the new size correctly. It doesn't seem to be reproducing for me though?

Chaphasilor commented 1 month ago

I only have the issue in the release build on Android. Could that be it?

Komodo5197 commented 1 month ago

Maybe? I’ll try a release build later.

Komodo5197 commented 1 month ago

It does seem to be a release-only issue. I've put a fix into #749.