search

jmshrv / finamp

A Jellyfin music client for mobile
Mozilla Public License 2.0
1.67k stars 117 forks source link

Appstream validation for metainfo.xml #763

Closed baarkerlounger closed 4 weeks ago

baarkerlounger commented 4 weeks ago

Fixes Appstream validation of the metainfo file. This should resolve the flathub build failure.

baarkerlounger commented 4 weeks ago

@Chaphasilor this should fix the flathub build error. Could you update the release assets again please?

Chaphasilor commented 4 weeks ago

Sure, will do!

Chaphasilor commented 4 weeks ago

done

Chaphasilor commented 4 weeks ago

@baarkerlounger I've updated the ID to be lowercase here, but can't edit the flathub PR. Could you please handle the requested changes there? Keep in mind that the file names in the bundle are different now!

baarkerlounger commented 4 weeks ago

@Chaphasilor will do. The name in the desktop file should probably also be updated but not sure if that'll break the arch build

Chaphasilor commented 4 weeks ago

@Maxr1998 any thoughts?

Maxr1998 commented 4 weeks ago

Not sure what's referred to here. Could you please elaborate?

Chaphasilor commented 4 weeks ago

Hmm, I'm not sure either. I assuned there was some kind of ID in the m4 desktop file, but that doesn't seem to be the case?

Maxr1998 commented 4 weeks ago

Nope, there's only a display name and an identifier for the icon file.