jmshrv / finamp

A Jellyfin music client for mobile
Mozilla Public License 2.0
1.67k stars 117 forks source link

[Bug]: Deselecting a music library has no effect #784

Open MattBlackOnly opened 1 week ago

MattBlackOnly commented 1 week ago

I have multiple music libraries, but I cant deselect any from the "Select Music Libraries" settings page. As it just reverts back to selecting all.

  1. Open settings
  2. Hit select music libraries
  3. Deselect a library
  4. Hit the tick button on the bottom right (accept?)
  5. Go back in and they are all selected again...

Any ideas?

Chaphasilor commented 1 week ago

Is that on the stable version or beta version?
For me it works as expected on the latest beta (0.9.8)...

MattBlackOnly commented 1 week ago

Is that on the stable version or beta version? For me it works as expected on the latest beta (0.9.8)...

It's 0.6.23 on Android. And using Jellyfin 10.9.6 Server.

Chaphasilor commented 1 week ago

Okay, thanks for confirming. Deselecting the library only hides it from the menu/drawer, it doesn't prevent tracks from it appearing in a playlist, artist, or instant mix.

But I'll try to fix this sometime :)

MattBlackOnly commented 1 week ago

Okay, thanks for confirming. Deselecting the library only hides it from the menu/drawer, it doesn't prevent tracks from it appearing in a playlist, artist, or instant mix.

But I'll try to fix this sometime :)

What about Playlists? In Jellyfin they appear as there own entity (kind of like a separate library)

I think you should be able to play any playlist no matter which library you have selected. But inversely those tracks should not show up in search or artist/albums... just my convoluted opinion, not sure what you think

Chaphasilor commented 1 week ago

Yeah playlists are shown in all libraries and load all included tracks, no matter which library is active. This is already how Finamp does things :)