Fix chinese font incorrectly rendered on Windows Desktop

jmshrv / finamp

A Jellyfin music client for mobile

Mozilla Public License 2.0

1.87k stars 123 forks source link

Fix chinese font incorrectly rendered on Windows Desktop #793

Closed lifegpc closed 3 months ago

lifegpc commented 3 months ago

Flutter 3 have font renderer issues on Windows. (For details, see https://github.com/flutter/flutter/issues/103811 ) The simplest way to resolve this issue is add zh_CN to supportedLocales. Before apply patch:

After apply patch:

Some characters still incorrectly rendered because speficied font weight is not available on Chinese default font and fallback to English font. (See https://github.com/flutter/flutter/issues/105014 )

Chaphasilor commented 3 months ago

Thanks for the fix! That seems like a simple patch and I don't think it would break anything else, so I'm happy to merge it!

If font weights are causing bigger issues (which seems to be the case if the wrong characters are used), you could also propose a fix for that. If there's a specific font weight that does work well we could discuss changing the default to that one instead :)