search

jmshrv / finamp

A Jellyfin music client for mobile
Mozilla Public License 2.0
1.97k stars 130 forks source link

Fade audio on pause/resume #799

Open Ambient-Impact opened 4 months ago

Ambient-Impact commented 4 months ago

As someone who enjoys loud music, I find it way more pleasant to have it fade out quickly (like 200 ms or so?) and it feels less jarring or like I've hit a brick wall when I pause a track. I've used Poweramp on Android for years, and this is the one feature I miss switching over to Jellyfin and Finamp. Awesome work with the redesign by the way.

Chaphasilor commented 3 months ago

Hey, thanks!
That should be possible to do, by simply quickly changing the volume, as suggested here: https://stackoverflow.com/questions/69508649/how-can-i-fade-in-and-fade-out-audio-in-just-audio

Not a priority for me, but if you or anyone else wants to tackle this, I'd be happy to accept a PR! It should be relatively easy to implement :)

Ambient-Impact commented 3 months ago

I'd love to if I had any experience working with any of this, but I'm a web developer and never worked on a native app; I know the limits of my knowledge far too well. 🤓

Chaphasilor commented 3 months ago

Dart is very similar to JavaScript, and you're not really touching native code. It would be similar to working with the Web Audio API in this case. You'd just need some OOP knowledge to understand how to overwrite methods of parent classes.

But no pressure! Just, feel free to ask if you'd to contribute :)

Ambient-Impact commented 3 months ago

True, Dart is pretty similar, and I do a ton of OOP stuff so that part I have a really good knowledge of. I'll think about it, though right now I'm short on time for these sorts of things because I have to gather bill repellent. 😭