search

jmshrv / finamp

A Jellyfin music client for mobile
Mozilla Public License 2.0
2k stars 130 forks source link

Use EdgeToEdge ui overlay mode on Android #940

Closed pohuing closed 2 weeks ago

pohuing commented 3 weeks ago

This addresses #917

Album view Player screen Song detail bottom sheet
Screenshot_20241101-214733 Screenshot_20241101-214738 Screenshot_20241101-214744
Chaphasilor commented 3 weeks ago

Hey, thanks for the PR and sorry for not getting back to you about it (or your issue) earlier!
I saw the notification and while I'm also a bit annoyed by the black bar I was to busy to get to it yet.

I'll give this a try right now!

pohuing commented 3 weeks ago

All good, my issue mentioned me trying to fix this anyways. I don't have an iPhone so it would be good someone could take a look whether this change messes up the status bar in light mode on the sign in screen.

Chaphasilor commented 3 weeks ago

Yeah that's much better, nice! I can't test iOS either, but maybe @jmshrv could take a look at some point...
I'll probably merge this either way sometime this week for the next release! Thanks again :)

PS: I'll also try to improve the alignment for the queue button's icon, that line break looks terrible with the German translation 😅
Edit: fixed in 6cd6e9252b87151882f2d82e52721f8c2ed71431

jmshrv commented 2 weeks ago

This works fine on iOS :D

Chaphasilor commented 2 weeks ago

Perfect! Happily merged :D