jmstrat / Echem.Data

Importing electrochemistry data into R
GNU Affero General Public License v3.0
1 stars 0 forks source link

Unmapped Column Types #3

Closed cstjohn810 closed 3 years ago

cstjohn810 commented 3 years ago

Prerequisites

Describe the bug

When loading in Biologic .mpr files, I get a couple of unmapped columns - dQ.C and (Q-Qo).C

To Reproduce

# Minimal code that demonstrates the problem
echem_file <- read.echem("file.mpr")

Expected behavior

Should read in files without warning

Operating environment

Copy and paste the output of running sessionInfo() here: R version 4.1.1 (2021-08-10) Platform: x86_64-w64-mingw32/x64 (64-bit) Running under: Windows 10 x64 (build 18363)

Attachments NA

jmstrat commented 3 years ago

This is just the result of an overzealous warning, it means there isn't a normalised version of that column name that will be the same across every supported cycler type. As the warning is fairly meaningless, I've removed it as part of #4 – when this is merged the file will import without warnings.

Despite the warnings, the file itself should still be imported correctly. For example the following should still work:

# import the data
echem_file <- read.echem("file.mpr")
# basic plot
plot(echem_file)
# look at the raw data
View(echem_file)
# etc.

If the data are not imported correctly imported, please attach an example file and let me know what's wrong.

cstjohn810 commented 3 years ago

Great, thank you - that makes sense. The file import does look like it happened correctly but I was thinking the warning meant those columns wouldn't be mapped. Thank you for this package by the way - it saved me tons of time trying to figure out the binary import myself.

jmstrat commented 3 years ago

Ok great, in which case I'll merge #4 which will close this issue