jmsv / ety-python

A Python module to discover the etymology of words
http://ety-python.rtfd.io
MIT License
144 stars 18 forks source link

Update to Python 3.7 #48

Closed alxwrd closed 6 years ago

alxwrd commented 6 years ago

Python 3.7 was released yesterday/today πŸŽ‰ πŸŽ‰

This adds 3.7 to the Travis file and the setup file.

Tests are running fine, except we are now getting FutureWarning's from pycodestyle as part of PEP 565 (Improved DeprecationWarning handling).

I am curious to see if the Travis build for 3.7 fails, as nightly was previously failing to build.

alxwrd commented 6 years ago
Unable to download 3.7 archive. The archive may not exist. Please consider a different version.

I guess we wait for Travis to add 3.7 to their s3 bucket.

alxwrd commented 6 years ago

See also travis-ci#9069

jmsv commented 6 years ago

:watch: :eyes: :snake:

codecov-io commented 6 years ago

Codecov Report

Merging #48 into master will increase coverage by 0.24%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
+ Coverage   92.11%   92.35%   +0.24%     
==========================================
  Files           7        7              
  Lines         279      301      +22     
==========================================
+ Hits          257      278      +21     
- Misses         22       23       +1
Impacted Files Coverage Ξ”
ety/word.py 84.31% <0%> (-0.8%) :arrow_down:
tests.py 99.19% <0%> (+0.11%) :arrow_up:
ety/language.py 73.33% <0%> (+4.1%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update 5dbba70...dd28f64. Read the comment docs.

alxwrd commented 6 years ago

So a build for Ubuntu Xenial (16.04) allows building with Python 3.7, but doesn't support Python 3.4. πŸ€”

Do we remove 3.4 support, or add conditionals to the .travis.yml file?

jmsv commented 6 years ago

@alxwrd Thanks for looking into this!

I'm hesitant to remove 3.4 support in trying to keep as much compatibility as possible

Looking at the requests Travis config, they use the following versions:

- "2.7"
- "3.4"
- "3.5"
- "3.6"
- "3.7-dev"

Could we use 3.7-dev until 3.7 is fully supported?

Also, do we need sudo: true? I think it's probably best to disable sudo if we can

alxwrd commented 6 years ago

I think 3.7-dev is a bit out of date. I'll make some commits to see if I can get anything to work well.