jmsv / ety-python

A Python module to discover the etymology of words

http://ety-python.rtfd.io

MIT License

144 stars 18 forks source link

Remove Pipfile.lock #50

Closed alxwrd closed 5 years ago

alxwrd commented 5 years ago

hello 👋 !

I was having an issue where getting an environment set up on a Windows machine was causing issues with colorful because colorama wasn't being installed. It's only a dependency on Windows, see here.

git clone https://github.com/jmsv/ety-python.git
cd ety-python
pipenv install .
python
>>> import ety
  File "...\site-packages\colorful\__init__.py", line 28, in <module>
    from colorama import init
ModuleNotFoundError: No module named 'colorama'

I've regenerated Pipfile.lock on a windows machine so colorama gets included. This has also bumped some version numbers, but tests are still passing locally.

codecov[bot] commented 5 years ago

Codecov Report

Merging #50 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #50   +/-   ##
=======================================
  Coverage   92.58%   92.58%           
=======================================
  Files           8        8           
  Lines         310      310           
=======================================
  Hits          287      287           
  Misses         23       23

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 886002d...139bb9a. Read the comment docs.

jmsv commented 5 years ago

Whoops! always missing the windowsy problems

Doesn't Pipfile.lock get regenerated when adding dependecies? I'm worried this change could get easily overwritten in the future - could colorama be added as a dependency in Pipfile?

alxwrd commented 5 years ago

🤔 Maybe the solution here is to remove Pipfile.lock from source control?

It seems weird to have colorama as an ety dependency because it's a colorful dependency.

jmsv commented 5 years ago

Ahhh that's a good idea. I didn't know about this:

Do not keep Pipfile.lock in version control if multiple versions of Python are being targeted.

Feel free to update this PR removing Pipfile.lock and adding to .gitignore

codecov-io commented 5 years ago

Codecov Report

Merging #50 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #50   +/-   ##
=======================================
  Coverage   92.58%   92.58%           
=======================================
  Files           8        8           
  Lines         310      310           
=======================================
  Hits          287      287           
  Misses         23       23

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 886002d...847005b. Read the comment docs.

jmsv commented 5 years ago

thanks @alxwrd :+1: