search

jmsv / l293d

Python module to drive DC motors from a Raspberry Pi using the L293D chip
http://l293d.rtfd.io
MIT License
18 stars 15 forks source link

Needs option to use BCM GPIO numbering #5

Closed jmsv closed 8 years ago

jmsv commented 8 years ago

BOARD numbers are currently used, but user could also have the option to use BCM numbering.

Difference between BOARD and BCM

See pinout.xyz for reference.

SmithcS commented 8 years ago

I'm not sure if I can assign myself to this, but I'll start working on this (and possibly issue #10) too

jmsv commented 8 years ago

@SmithcS Yeah it says you've assigned yourself :) Btw do you have Twitter or anything that I can IM you on? I can do #10 if you want, it's just a quick one: I wanted some of the code at the top of l293d.py to be put into methods.

Edit: I've closed #10

SmithcS commented 8 years ago

I do have an ancient Twitter account ill bring back to life - I pass you my handle after I reset the password

On Sep 25, 2016, at 13:56, James Vickery notifications@github.com wrote:

@SmithcS Yeah it says you've assigned yourself :) Btw do you have Twitter or anything that I can IM you on? I can do #10 if you want, it's just a quick one: I wanted some of the code at the top of l293d.py to be put into methods.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

jmsv commented 8 years ago

@SmithcS Okay thanks. Are you getting very far with this issue? Don't worry if not, I could do it soon

SmithcS commented 8 years ago

Hey - yep I started working on it Monday, however I've been busy at work the past couple days. Sorry for leaving it in limbo, I'll probably finish up with it sometime today/tomorrow.

On Wed, Sep 28, 2016 at 10:15 AM, James Vickery notifications@github.com wrote:

@SmithcS https://github.com/SmithcS Okay thanks. Are you getting very far with this issue? Don't worry if not, I could do it soon

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jamesevickery/l293d/issues/5#issuecomment-250198072, or mute the thread https://github.com/notifications/unsubscribe-auth/AKr-CKfvP3J6NLlFkLWWIMp1ezdH2Ep9ks5quoSMgaJpZM4J_o1e .

jmsv commented 8 years ago

@SmithcS Could you get this checked in soon? There's some other stuff I want to do but it would be a nightmare trying to merge it 👍

SmithcS commented 8 years ago

Hey! Sorry that took so long. Just made a pull request for you to check in.

On Sep 30, 2016, at 6:42 PM, James Vickery notifications@github.com wrote:

@SmithcS https://github.com/SmithcS Could you get this checked in soon? There's some other stuff I want to do but it would be a nightmare trying to merge it 👍

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jamesevickery/l293d/issues/5#issuecomment-250876353, or mute the thread https://github.com/notifications/unsubscribe-auth/AKr-CKOk_srbgv2A0vrj523_97QCkluLks5qvZ5tgaJpZM4J_o1e.

jmsv commented 8 years ago

Thanks! Btw I don't actually have L293D chips and motors with me for a while - if you've been using this library could you tell me if something stops working? I've only been developing while test_mode = True.

SmithcS commented 8 years ago

I have some motors but not the chips, I'll order some off of amazon.