jmtellez / CLI-mate

Node CLI app that gives you the weather forecast for a given city.

6 stars 10 forks source link

Feature/add dotenv #18

Closed Walter-Dalla closed 3 years ago

Walter-Dalla commented 3 years ago

ADD: It is now easier to configure the env variables, just put them in .env!

This change was documented in readme.md as:

FIXED: If your geocode token were invalid, it would generate an undefined error:

Now it will print the error message to the user, like this:

Walter-Dalla commented 3 years ago

hacktoberfest

jmtellez commented 3 years ago

@Walter-Dalla can you run npm link on root directory and then from any other path run cli-mate <location> I tried using dotenv module but when creating symlink to project it cannot find it.

aaronzshey commented 3 years ago

Thanks - this should be merged ASAP - I thought those errors were on my machine haha.

jmtellez commented 3 years ago

error will occur if you dont have the env vars

jmtellez commented 3 years ago

this project does not require dotenv as its meant to be installed through npm. dotenv would only work for contributors when testing