Closed aaronzshey closed 3 years ago
What's the status on this PR? Should I make any further changes?
There are some conflicts, resolve them, and pull new changes. Use arrow functions for auto-locate
and only commit correct files.
Ok, I'll work on that.
You are not calling auto-locate anywhere, also just commit the files you are changing, so basically just ./utils/autolocate
and app.js if you are planning to make the call. I can make the call if you'd like
Yeah, I was just going to add ./utils/autolocate because I think some changes were made to app.js.
Right now I think the only change is in autolocate.js - is there anything else I should do? Every time I try to edit app.js there are conflicting changes.. There's a comment at the end of autolocate.js with some simple directions on using the functions; I could expand on that.
if the changes are only on autolocate.js
just commit that file. It should only be one file changed
I can then call your function on entry file app.js
Ok! I'm going to delete this pull request and open a new one with only one changed file.
Added ./utils/auto-locate.js. Function exported and can be used as autoLocate() - it accepts a callback as an argument, hopefully it works. Also, I changed the readme to differentiate this from the original repo - make sure not to merge the readme edits by mistake.