search

jmurphyau / ember-truth-helpers

Ember HTMLBars Helpers for {{if}} & {{unless}}: not, and, or, eq & is-array
MIT License
706 stars 95 forks source link

Update to ember-cli-babel@7 #116

Closed mehulkar closed 4 years ago

mehulkar commented 4 years ago

I include ember-truth-helpers as part of my own addon (let's say ember-foo-bar) in dependencies. When I install ember-foo-bar in an app that has config/targets.js set to add include Safari 13, ember serve breaks.

I believe this is happening because ember-cli-babel from here is being used as a preprocess because it's in dependencies of ember-foo-bar, and that preprocessor has an outdated version of browserslist which throws because it doesn't know about Safari 13.

Some workarounds I can think of but haven't tested yet:

But I'm filing this since ember-cli-babel@7 has been out for a while and it probably makes sense to update it here too.

rwjblue commented 4 years ago

How does ember serve break? Does it throw an error (if so, can you share the stack trace)?

SergeAstapov commented 4 years ago

@mehulkar a new version v3.0 of this addon was pushed today, looks like this should be resolved?