search

jmurphyau / ember-truth-helpers

Ember HTMLBars Helpers for {{if}} & {{unless}}: not, and, or, eq & is-array
MIT License
706 stars 95 forks source link

Update Ember CLI Babel to 7.26.11 #149

Closed NEWeber closed 1 year ago

NEWeber commented 2 years ago

Fixes #148

This should fix the deprecation warnings for Ember Globals

SergeAstapov commented 2 years ago

@NEWeber FYI I doubt this would fix anything as this addon already allows versions ^7.22.1 hence you may be able to easily bump to the latest by manipulating your lock file or recreating one.

NEWeber commented 2 years ago

@SergeAstapov, good point. I'll do that in the meantime.

Is there any reason not to merge this? The tests pass and will ensure that other users won't have to tinker with their lock files.

SergeAstapov commented 2 years ago

@NEWeber it does not hurt to land this and get released of course. It just may cause churn and conflicts for #149 which I would prefer to land

locks commented 1 year ago

This is no longer relevant. Both packages that have ember-cli-babel as a dependency already specify 7.26.11 😁 Sorry for not getting to the PR sooner.