search

jmurphyau / ember-truth-helpers

Ember HTMLBars Helpers for {{if}} & {{unless}}: not, and, or, eq & is-array
MIT License
706 stars 95 forks source link

Typescript conversion #163

Closed bakerac4 closed 1 year ago

bakerac4 commented 1 year ago

Would the owners/mantainers of this repo accept a PR to convert this to typescript? I'd like to be able to have the types from this repo and remove them from @gavant/glint-template-types. We use this in every project so it would benefit us greatly (and I believe the wider community?)

But I don't want to start without getting acknowledgment so I know it would eventually be accepted.

@jmurphyau

nlfurniss commented 1 year ago

I image maintainers would be happy to review PRs. My suggestion would be to break it down into multiple PRs instead of one massive one doing the conversion. This makes it much easier and faster to review.