Fix Glint types by converting helpers to plain functions

[NullVoxPopuli]

This is a breaking change without the polyfill, and would require ember-source@4.5 without said polyfill.

This conversion to normal functions cooincidentally fixes the triple slash issue, described

• here: https://github.com/tracked-tools/ember-async-data/pull/704
• and: https://github.com/tildeio/ember-element-helper/issues/111

[SergeAstapov]

@NullVoxPopuli thanks for submitting this! Do you see this solve any TS issues we tried to solve and couldn't in #185?

[NullVoxPopuli]

perhaps!

[SergeAstapov]

@NullVoxPopuli and other who follow: I tried to bump this in our app (via https://github.com/jmurphyau/ember-truth-helpers/tree/helpers-as-plain-functions-dist) and see many of tests fail, will look into root cause why behavior is different.

Glint and TS were happy though.

[NullVoxPopuli]

I tried to bump this in our app

do you have a reproduction?

[SergeAstapov]

I tried to bump this in our app

do you have a reproduction?

sorry, it's behind VPN. I'm digging what exactly is the issue and if it's our app code or the lib code issue

[NullVoxPopuli]

Made a tool to help out in the future: https://github.com/NullVoxPopuli/fix-bad-declaration-output